Fixing dismatch between dense matrix() and sparse repr sparse_matrix() of GlobalPhase
#6940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
JerryChen97
commented
Feb 7, 2025
JerryChen97
commented
Feb 7, 2025
JerryChen97
changed the title
matrix() and sparse repr sparse_matrix() of GlobalPhase
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6940 +/- ##
==========================================
- Coverage 99.59% 99.59% -0.01%
==========================================
Files 480 480
Lines 45510 45516 +6
==========================================
+ Hits 45325 45330 +5
- Misses 185 186 +1 ☔ View full report in Codecov by Sentry. |
astralcai
reviewed
Feb 10, 2025
…erparams' into fix-GlobalPhase-hyperparams
astralcai
approved these changes
Feb 10, 2025
JerryChen97
commented
Feb 10, 2025
| # global phase | ||
| wires = wire_order[0:1] | ||
| if qml.math.shape(mat) == (qudit_dim, qudit_dim): | ||
| wires = wire_order[0:1] |
There was a problem hiding this comment.
It seems that the line119 has never been visited by the whole codebase. This means it actually only serves for the previous wrong impelmentation of GlobalPhase(.., wires=None). So we will just delete this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
qml.GlobalPhasedoes not set itshyperparametersduring initialization. This caused certain bugs, e.g.where
GlobalPhase.sparse_matrix()did the calculation wrongly because it never received correctn_wiresfromhyperparameters, which is required by the base classOperatorDescription of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: